BH-98761 - fixing deliveryMethodLookup #462
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leemarscott
requested review from
acrowe2,
davidkbh,
jordanbullhorn and
ndickerson
ndickerson
reviewed
Jan 5, 2026
| insertOrUpdateEntity(); | ||
|
|
||
| // Only call insertOrUpdateEntity if there are direct fields to persist, or if it's a new entity | ||
| if (isNewEntity || hasDirectFieldsToPopulate) { |
Member
There was a problem hiding this comment.
These code changes look good, and I see the addition of the example for the integration test, but I don't see any new unit tests for this new functionality. You probably want to add unit tests for billing profile and entities without direct fields to populate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What did you change?