Skip to content

Conversation

@gazayas
Copy link

@gazayas gazayas commented Jul 10, 2023

Besides the changes I added here, the following two methods stood out to me:

  1. keyDownFunction
  2. keyUpFunction

There's some duplicate code here so I'd be glad to refactor some of it, but it looks like these methods aren't being used in the first place:

// document.addEventListener('keydown', function(e){keyDownFunction(e)}, true);
// document.addEventListener('keyup', function(e){keyUpFunction(e)}, true);

For that reason I won't worry about it too much now, but if we just want to get rid of these methods I can go head and delete them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants