(Fix) Platform api changes to support phase 1 of Dockerfiles implementation #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
Deprecate the CNB Bindings spec
Update codeowners to reflect governance structure
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
The 80 range is for the launcher. Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Co-authored-by: Javier Romero <rjavier@vmware.com> Signed-off-by: Natalie Arellano <narellano@vmware.com>
Co-authored-by: Javier Romero <rjavier@vmware.com> Signed-off-by: Natalie Arellano <narellano@vmware.com>
Co-authored-by: Javier Romero <rjavier@vmware.com> Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Terence Lee <hone02@gmail.com>
add platform team lead as a co-codeowner of distribution spec
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
jromero
approved these changes
Aug 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#308 was merged accidentally into the wrong branch.
Note also the addition of 27ad6ed which nixes
-output-dirin favor of-generated, to be more consistent with the arguments needed by the extender in phase 2.