Skip to content

Fix: when running restore, provide creds for run image if there are r… #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkutner merged 3 commits into from
Jul 10, 2023
Merged

Fix: when running restore, provide creds for run image if there are r… #1815

jkutner merged 3 commits into from
Jul 10, 2023

Conversation

@natalieparellano
Copy link
Member

@natalieparellano natalieparellano commented Jun 28, 2023

…un image extensions

Otherwise the restorer could fail to find the run image, resulting in unexpected behavior

Summary

Output

Before

After

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #___

@github-actions github-actions bot added this to the 0.30.0 milestone Jun 28, 2023
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Jun 28, 2023
@natalieparellano
Copy link
Member Author

natalieparellano commented Jun 28, 2023

Will undraft once tests are added

Fix: when running restore, provide creds for run image if there are r…
8c5813d 
…un image extensions

Otherwise the restorer could fail to find the run image, resulting in unexpected behavior

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano marked this pull request as ready for review June 30, 2023 14:41
@natalieparellano natalieparellano requested review from a team as code owners June 30, 2023 14:41
@natalieparellano natalieparellano mentioned this pull request Jun 30, 2023
Merged
@natalieparellano
Copy link
Member Author

natalieparellano commented Jun 30, 2023

See buildpacks/lifecycle#1134 (comment) for further evidence that this fix does what it is supposed to

jjbustamante
jjbustamante approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@jjbustamante jjbustamante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Fix: also provide creds if the run image reference changed (even if i…
16bd357 
…t was only switched and we don't need to run extend)

as the restorer also needs to update the digest & target data.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
joe-kimmel-vmw
joe-kimmel-vmw approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@joe-kimmel-vmw joe-kimmel-vmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkutner jkutner enabled auto-merge July 10, 2023 12:53
@jkutner jkutner merged commit f9149b7 into main Jul 10, 2023
@jkutner jkutner deleted the fix/creds-for-run-ext branch July 10, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkutner jkutner jkutner approved these changes

@jjbustamante jjbustamante jjbustamante approved these changes

@joe-kimmel-vmw joe-kimmel-vmw joe-kimmel-vmw approved these changes

Assignees

No one assigned

Labels

type/enhancement Issue that requests a new feature or improvement.

Projects

None yet

Milestone

0.30.0

Development

Successfully merging this pull request may close these issues.

5 participants

@natalieparellano @jkutner @jjbustamante @joe-kimmel-vmw