fix: prevent setup-status hang with timeout/retry + retry UI#457
Merged
Conversation
- add bounded timeout+retry helper for /api/setup checks - show actionable setup error state with Retry button - avoid blank-screen fallback when setup status check fails - add unit tests for retry helper Fixes #456
📸 Screenshot Drift CheckThis PR modifies UI source files. Please verify whether the README screenshots need refreshing:
Changed UI filesSee This comment is posted automatically and can be dismissed if no visual changes occurred. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the setup page hang scenario where users can get stuck on "Checking Setup Status..." indefinitely.
What changed
fetchSetupStatusWithRetryhelper (src/lib/setup-status.ts) with:src/app/setup/page.tsxto use timeout+retry helper for initial setup checkreturn null) with a visible error state + Retry buttonsrc/lib/__tests__/setup-status.test.ts)Why
Issue #456 reported setup flow hanging at "Checking Setup Status...". The prior code used a bare
fetch('/api/setup')with no timeout/retry, and on failed check could also fall into a blank UI path.Test plan
pnpm exec tsc --noEmitpnpm exec vitest run src/lib/__tests__/setup-status.test.tsFixes #456