fix: preserve gateway device auth when registering MC origin#434
Closed
eloe wants to merge 1 commit intobuilderz-labs:mainfrom
Closed
fix: preserve gateway device auth when registering MC origin#434eloe wants to merge 1 commit intobuilderz-labs:mainfrom
eloe wants to merge 1 commit intobuilderz-labs:mainfrom
Conversation
e5400ce to
430ab9c
Compare
Member
|
Thanks for the regression coverage here. I didn’t merge this PR directly because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gateway.controlUi.dangerouslyDisableDeviceAuthwhen Mission Control registers its dashboard originregisterMcAsDashboard()limited togateway.controlUi.allowedOriginsRisk Level
Low
Tests
pnpm lintpnpm typecheckpnpm testpnpm buildpnpm quality:gateSecurity Review
This change touches gateway auth posture. The previous behavior could silently set
gateway.controlUi.dangerouslyDisableDeviceAuth=trueduring Mission Control dashboard-origin registration, weakening OpenClaw device authentication. This fix preserves the existing device-auth setting and limits registration to adding the Mission Control origin togateway.controlUi.allowedOrigins.Checklist