Traceback and Configuration Fixes. #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Couldn't the comments be removed? Simply documenting them should be enough right but commenting everything you want to say will just clutter codebase |
Author
|
They can obviously be removed. Just make sure to understand it and that it doesn't happen again. |
markination
reviewed
Jan 2, 2026
| try: | ||
| await Channel.send(embed=embed, files=files) | ||
| except Exception as e: | ||
| except Exception: |
Contributor
There was a problem hiding this comment.
This needs to actually reference the exception
except Exception as e:
otherwise the code in the block will not work
markination
reviewed
Jan 2, 2026
| ) | ||
| except Exception as e: | ||
| except Exception: | ||
| import traceback |
Contributor
There was a problem hiding this comment.
Imports should be at top of file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed traceback fixes, it takes 0 arguments for "print_exc" or "format_exc" to work, I have remove the exception from the arguments, there was also a website link without the slash needed, I fixed it: "https:/docs.astrobirb.dev fixed to -> https://docs.astrobirb.dev".