Update nipunn1313-mypy plugins to the latest #2105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update plugins to use bookworm based build image and distroless base image. Fixes #2104.
stefanvanburen
approved these changes
Nov 18, 2025
Member
stefanvanburen
left a comment
stefanvanburen
left a comment
There was a problem hiding this comment.
seems reasonable — did we have a similar issue w/ other python plugins?
pkwarren
commented
Nov 18, 2025
| # https://github.com/nipunn1313/mypy-protobuf/tree/v3.7.0#requirements-to-run-typecheckers-on-stubs-generated-by-mypy-protobuf | ||
| # > Earlier releases might work, but aren't tested. | ||
| - "types-protobuf >= 5.28" | ||
| - "protobuf >= 5.28.2" |
Member
Author
There was a problem hiding this comment.
Updated these deps based on the latest documented versions.
| WORKDIR /app | ||
| RUN python -mvenv /app | ||
| ADD /requirements.txt requirements.txt | ||
| RUN . ./bin/activate \ |
Member
Author
There was a problem hiding this comment.
Had to switch source to . for the build to work. Switched this plugin to use distroless python.
mfridman
approved these changes
Nov 18, 2025
Member
Author
I think I'd updated other ones already. This plugin was building on an alpine image and deploying w/ debian based one. |
mfridman
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update plugins to use bookworm based build image and distroless base image.
Fixes #2104.