Update biome, expand coverage for linting and formatting, fix new errors

biome.json

@@ -1,7 +1,45 @@
 {
-  "$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
-  "extends": ["./biome.base.json"],
+  "$schema": "https://biomejs.dev/schemas/2.3.8/schema.json",
+  "vcs": {
+    "enabled": false,
+    "clientKind": "git",
+    "useIgnoreFile": true
+  },
   "files": {
-    "ignore": ["packages/**"]
+    "ignoreUnknown": false,
+    "includes": [
+      "*",
+      "src/**",
+      "scripts/**",
+      "!tsconfig.*.json",
+      "!**/gen",
+      "!**/dist",
+      "!.turbo"
+    ]
+  },
+  "formatter": {
+    "indentStyle": "space"
+  },
+  "linter": {
+    "rules": {
+      "recommended": true,
+      "style": {
+        "useTemplate": "off",
+        "useConst": "off",
+        "noParameterAssign": "off",
+        "useSingleVarDeclarator": "off",
+        "useNumberNamespace": "off",
+        "noUnusedTemplateLiteral": "off",
+        "useEnumInitializers": "off"
+      },
+      "correctness": {
+        "noSwitchDeclarations": "off"
+      },
+      "suspicious": {
+        "noDoubleEquals": "off",
+        "noFallthroughSwitchClause": "off",
+        "noCatchAssign": "off"
+      }
+    }
   }
 }

package.json

@@ -10,7 +10,11 @@
     "license-header": "license-header --ignore 'packages/**'",
     "lint": "biome lint --error-on-warnings"
   },
-  "workspaces": ["packages/cel-spec", "packages/cel", "packages/example"],
+  "workspaces": [
+    "packages/cel-spec",
+    "packages/cel",
+    "packages/example"
+  ],
   "type": "module",
   "packageManager": "npm@10.9.0",
   "licenseHeader": {
@@ -20,7 +24,7 @@
   },
   "devDependencies": {
     "@arethetypeswrong/cli": "^0.18.2",
-    "@biomejs/biome": "^1.9.4",
+    "@biomejs/biome": "^2.3.8",
     "@bufbuild/buf": "^1.61.0",
     "@bufbuild/license-header": "^0.0.4",
     "@bufbuild/protoc-gen-es": "^2.10.1",

packages/cel-spec/biome.json

@@ -1,7 +1,8 @@
 {
-  "$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
-  "extends": ["../../biome.base.json"],
+  "root": false,
+  "$schema": "https://biomejs.dev/schemas/2.3.8/schema.json",
+  "extends": "//",
   "files": {
-    "ignore": ["dist", "src/wkt/gen", "src/testdata/conformance.ts"]
+    "includes": ["!**/src/testdata/conformance.ts"]
   }
 }

packages/cel-spec/package.json

@@ -123,24 +123,42 @@
   },
   "typesVersions": {
     "*": {
-      "testdata/conformance.js": ["./dist/cjs/testdata/conformance.d.ts"],
+      "testdata/conformance.js": [
+        "./dist/cjs/testdata/conformance.d.ts"
+      ],
       "testdata/parser-comprehensions.js": [
         "./dist/cjs/testdata/parser-comprehensions.d.ts"
       ],
       "testdata/parser-conformance.js": [
         "./dist/cjs/testdata/parser-conformance.d.ts"
       ],
-      "testdata/parser.js": ["./dist/cjs/testdata/parser.d.ts"],
-      "testdata/registry.js": ["./dist/cjs/testdata/registry.d.ts"],
-      "testdata/simple.js": ["./dist/cjs/testdata/simple.d.ts"],
+      "testdata/parser.js": [
+        "./dist/cjs/testdata/parser.d.ts"
+      ],
+      "testdata/registry.js": [
+        "./dist/cjs/testdata/registry.d.ts"
+      ],
+      "testdata/simple.js": [
+        "./dist/cjs/testdata/simple.d.ts"
+      ],
       "testdata/to-debug-string.js": [
         "./dist/cjs/testdata/to-debug-string.d.ts"
       ],
-      "cel/expr/checked_pb.js": ["./dist/cjs/gen/cel/expr/checked_pb.d.ts"],
-      "cel/expr/eval_pb.js": ["./dist/cjs/gen/cel/expr/eval_pb.d.ts"],
-      "cel/expr/explain_pb.js": ["./dist/cjs/gen/cel/expr/explain_pb.d.ts"],
-      "cel/expr/syntax_pb.js": ["./dist/cjs/gen/cel/expr/syntax_pb.d.ts"],
-      "cel/expr/value_pb.js": ["./dist/cjs/gen/cel/expr/value_pb.d.ts"],
+      "cel/expr/checked_pb.js": [
+        "./dist/cjs/gen/cel/expr/checked_pb.d.ts"
+      ],
+      "cel/expr/eval_pb.js": [
+        "./dist/cjs/gen/cel/expr/eval_pb.d.ts"
+      ],
+      "cel/expr/explain_pb.js": [
+        "./dist/cjs/gen/cel/expr/explain_pb.d.ts"
+      ],
+      "cel/expr/syntax_pb.js": [
+        "./dist/cjs/gen/cel/expr/syntax_pb.d.ts"
+      ],
+      "cel/expr/value_pb.js": [
+        "./dist/cjs/gen/cel/expr/value_pb.d.ts"
+      ],
       "cel/expr/conformance/conformance_service_pb.js": [
         "./dist/cjs/gen/cel/expr/conformance/conformance_service_pb.d.ts"
       ],

packages/cel-spec/src/testdata/to-debug-string.ts

@@ -29,8 +29,6 @@ const decoder = new TextDecoder();
 // These expressions MUST capture a single character (a string `S` where `S.length == 1`)
 // @ts-expect-error - The regex flag `v` is only available in ES2024 or later
 const UNPRINTABLE_EXP: CharRegExp = /[^\p{L}\p{N}\p{S}\p{P}\p{Cs} ]/v;
-// @ts-expect-error - The regex flag `v` is only available in ES2024 or later
-const UNPRINTABLE_EXP_GLOBAL: CharRegExp = /[^\p{L}\p{N}\p{S}\p{P}\p{Cs} ]/gv;
 
 const SPECIAL_ESCAPES: Map<number, string> = new Map([
   [0x07, "\\a"],

packages/cel/biome.json

@@ -1,9 +1,7 @@
 {
-  "$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
-  "extends": ["../../biome.base.json"],
-  "formatter": {
-    "ignore": ["dist", "src/gen"]
-  },
+  "root": false,
+  "$schema": "https://biomejs.dev/schemas/2.3.8/schema.json",
+  "extends": "//",
   "linter": {
     "rules": {
       "suspicious": {

packages/cel/package.json

@@ -44,7 +44,9 @@
   },
   "typesVersions": {
     "*": {
-      "ext/strings": ["./dist/cjs/ext/strings/index.d.ts"]
+      "ext/strings": [
+        "./dist/cjs/ext/strings/index.d.ts"
+      ]
     }
   },
   "peerDependencies": {

packages/cel/src/map.ts

@@ -134,9 +134,9 @@ class NativeMap implements CelMap {
     // biome-ignore lint/suspicious/noExplicitAny: Part of the Map interface.
     thisArg?: any,
   ): void {
-    this._map.forEach((value, key, _) =>
-      callback.call(thisArg, toCel(value), key, this),
-    );
+    this._map.forEach((value, key, _) => {
+      callback.call(thisArg, toCel(value), key, this);
+    });
   }
 
   *entries(): MapIterator<[string | bigint | boolean | CelUint, CelValue]> {
@@ -188,14 +188,14 @@ class ProtoMap implements CelMap {
     // biome-ignore lint/suspicious/noExplicitAny: Part of the Map interface.
     thisArg?: any,
   ): void {
-    this._map.forEach((value, key, _) =>
+    this._map.forEach((value, key, _) => {
       callback.call(
         thisArg,
         celFromMapValue(this._map.field(), value),
         celFromMapKey(this._map.field(), key),
         this,
-      ),
-    );
+      );
+    });
   }
 
   *entries(): MapIterator<[string | bigint | boolean | CelUint, CelValue]> {