Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Feb 26, 2025

This is a successor to #3610.

Changed:

  • Update protovalidate to latest revision.
  • Update example linting code to use WithFilter
  • Still retains the other changes (removing support for deprecated protovalidate options.)

This uses an unreleased version of protovalidate-go, which was suggested so we could try to finalize the filter API before cutting a release with it.

Open question remains: should we try to warn users if the legacy removed protovalidate options are present, somehow? I assume this could be checked by looking for unknown fields in the options.

(This should unbreak the errors that occur when trying to use buf with go tool, although we do not recommend using go tool.)

@ghost ghost requested review from doriable and oliversun9 February 26, 2025 21:04
@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 17, 2025, 4:12 PM

@ghost ghost removed request for doriable and oliversun9 February 26, 2025 21:15
@ghost
Copy link
Author

ghost commented Feb 26, 2025

Seems like we are running into problems with the latest protobuf runtime.

@ghost ghost marked this pull request as draft February 26, 2025 21:17
@doriable
Copy link
Member

Seems like we are running into problems with the latest protobuf runtime.

This should be resolved on main, I'll keep an eye on this PR if there are more issues!

@doriable doriable marked this pull request as ready for review March 17, 2025 16:14
@doriable doriable merged commit bb7f914 into main Mar 17, 2025
10 checks passed
@doriable doriable deleted the jchadwick/update-protovalidate branch March 17, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants