Proposed changes to add format change functionality #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There might be a better/more elegant way of choosing the output format than the global variable format_mm. - Not sure if it is needed to save changes with sendCommand( SAVE_SETTINGS,0) just if the format is changed or it's not necessary at all. Could be removed or put inside the `if(format_mm==true)` after sending the command STANDARD_FORMAT_MM. - Changed the comments to match the new line numbers due to proposed changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format_mm.if(format_mm==true)after sending the command withSTANDARD_FORMAT_MM.