Skip to content

Conversation

@blackjid
Copy link
Contributor

@blackjid blackjid commented Apr 9, 2025

  • chore(github): run specs on ruby versions >= 3
  • feat(ruby): add support for ruby > 3

@blackjid blackjid force-pushed the add_support_ruby_3 branch 10 times, most recently from f5ca2c8 to 8a9ddf0 Compare April 16, 2025 13:08
@blackjid blackjid force-pushed the add_support_ruby_3 branch from 42621e5 to 582acdb Compare April 16, 2025 13:31
@blackjid blackjid requested review from a team and iobaixas April 16, 2025 13:33
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

por qué matrix?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pqe somos el mejor squad

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chuta, me quede colgado si la pregunta era de verdad o era por la talla...

Contesto igual...

strategy.matrix te permite definir un job que corra multiples veces en pararllelo. Y se puede interpolar valores en el job usando ${{ matrix.<key>}}

En este caso, corremos el mismo job para cada version de ruby, y usamos el valor para decirle a ruby-setup que instale esa version.

Ademas hay un caso expecial en que para ruby 2.7 agregamos otro valor, rubygems: 3.3.22, y usamos ese valor para actualizar ruby gems cuando estamos en el job 2.7

El fail-fast: false es por que en true (default) si uno de los jobs falla, los otros se cancelan.

Con el needs: [test] que hay en el siguiente job, hacemos que tengan que pasar todos los jobs paralalelos de test antes que se ejecute el siguiente

Copy link

@aundurraga aundurraga Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

era verdad jajaj

@blackjid blackjid merged commit cf860ac into master Apr 16, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants