This repository was archived by the owner on Jun 5, 2019. It is now read-only.
Improve security of and make optional certain user API parameters #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Users should already have their passwordDigest filtered out (it has a select: false on the attribute in the Mongoose Schema)
Contributor
|
Sorry about this @hulbert — Any chance you could merge with the most recent master branch? I'll merge as is and tidy up any bits later, thanks :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings over the hidden isAdmin checkbox from @davidkaneda's dropbox branch (this code doesn't work so well without it) and then actually makes the marked "optional" fields (in the apidoc) optional. It also adds to the apidoc the fact that the API takes an array of roles.
Finally, it does not allow non-administrators to submit roles.
A note about a past suggestion of using something like
_.extend user, _.pick req.body, 'name', 'email': I believe Mongoose's Document#set behaves similarly, and_.pickdoes not addkey: nullto the returned object if a parameter is missing so it should be okay to use this pattern ofdocument.set _.pick req.body 'param1', 'param2'for optional API field edits.