Skip to content

FIX : Payment fee is still charged #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gentiprenaj merged 1 commit into from
Mar 17, 2026
Merged

FIX : Payment fee is still charged #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Handlers/PaymentHandlerLegacy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ public function pay(
$paymentCode,
$salesChannelId
);
if ($fee > 0) {
$existingFee = (float) ($order->getCustomFieldsValue('buckarooFee') ?? 0.0);
if ($fee > 0 || $existingFee > 0) {
$this->asyncPaymentService
->checkoutHelper
->applyFeeToOrder($order->getId(), $fee, $salesChannelContext->getContext());
Expand Down
3 changes: 2 additions & 1 deletion src/Handlers/PaymentHandlerModern.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@
$paymentCode,
$order->getSalesChannelId()
);
if ($fee > 0) {
$existingFee = (float) ($order->getCustomFieldsValue('buckarooFee') ?? 0.0);

Check failure on line 100 in src/Handlers/PaymentHandlerModern.php

View workflow job for this annotation

GitHub Actions / Code Quality 

Cannot cast mixed to float.
if ($fee > 0 || $existingFee > 0) {
$this->feeCalculator->applyFeeToOrder($order->getId(), $fee, $salesChannelContext->getContext());
// Reload order to get updated total
$reloadedOrder = $this->asyncPaymentService->checkoutHelper->getOrderById(
Expand Down
3 changes: 2 additions & 1 deletion src/Handlers/PaymentHandlerSimple.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,8 @@
$paymentCode,
$salesChannelContext->getSalesChannelId()
);
if ($fee > 0) {
$existingFee = (float) ($order->getCustomFieldsValue('buckarooFee') ?? 0.0);

Check failure on line 271 in src/Handlers/PaymentHandlerSimple.php

View workflow job for this annotation

GitHub Actions / Code Quality 

Cannot cast mixed to float.
if ($fee > 0 || $existingFee > 0) {
$feeCalculator->applyFeeToOrder($order->getId(), $fee, $context);
// Reload order to get updated total
$order = $this->asyncPaymentService->checkoutHelper->getOrderById($order->getId(), $context);
Expand Down
Loading