Fix SyntaxError from non-raw regular expression#133
Open
effigies wants to merge 1 commit intobtel:masterfrom
Open
Fix SyntaxError from non-raw regular expression#133effigies wants to merge 1 commit intobtel:masterfrom
effigies wants to merge 1 commit intobtel:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that invalid escape sequences will at some undetermined point in the future stop emitting SyntaxWarnings and start emitting SyntaxErrors (see the second bullet item in https://docs.python.org/3/whatsnew/3.12.html#other-language-changes).
On the whole, svgutils seems not to need changes to be usable on new versions of Python, but this warning is no longer safe to ignore.
Only the first change is really necessary, but I used
pyupgrade --py36-plusto just make safe upgrades. I only included conversions away from%-formatted strings if they actually made the line shorter.