Conversion to ARC #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serg75
commented
Aug 4, 2022
Serg75
commented
- Fix issues preventing conversion to ARC. Part 1
- Added FastSet based on NSObject
- Fix issues preventing conversion to ARC. Part 2. Some ‘autorelease’ messages
- Fix issues preventing conversion to ARC. Part 3. Simplified image loader
- Fix issues preventing conversion to ARC. Part 4. Replaced Cocoa ‘release’ method by CFRelease function for static field
- Fix issues preventing conversion to ARC. Part 5. Added __bridge casts by Xcode autocorrection
- Fix issues preventing conversion to ARC. Part 6. Forward declaration warnings
- Fix issues preventing conversion to ARC. Part 7. One more ‘autorelease’ message
- Fix issues preventing conversion to ARC. Part 8. Removed LDrawFastSet
- Fix issues preventing conversion to ARC. Part 9. Removed ‘autorelease’ messages which will be managed by ARC
- Moved new GCD code into '#if USE_BLOCKS' preprocessor condition like other similar places
- Fix issues preventing conversion to ARC. Part 10. ‘release’ messages for unsafe_unretained properties
- Fix issues preventing conversion to ARC. Part 11. Added bridge casts for dispatch_group_t
- Fix issues preventing conversion to ARC. Part 12. ‘release’ message for readonly property
- Fix issues preventing conversion to ARC. Part 13. Removed definition for dispatch_queue_t in '!USE_BLOCKS' preprocessor directive
- Fix issues preventing conversion to ARC. Part 14. RegexKitLite.m excluded from ARC philosophy
- Conversion to ARC
- Get rid of dangerous unsafe_unretained properties
- Fixed leaks
- Fixed crash on minifigure creation second time (with changing parameters in minifugure dialog)
…ase’ method by CFRelease function for static field
… by Xcode autocorrection
…’ messages which will be managed by ARC
…other similar places
…for unsafe_unretained properties
…for dispatch_group_t
…or readonly property
…for dispatch_queue_t in '!USE_BLOCKS' preprocessor directive
…uded from ARC philosophy
…ers in minifugure dialog)
Author
|
@allenmonroesmith please review this PR |
It looks like the entire window is filled with some color
…tinue be visible after closing. Note, that approach only works with userDefinedRuntimeAttributes in xib.
…om being destroyed, causing app crashing when opening a menu on macOS 14
added 3 commits
February 6, 2024 13:41
… the focused ring
…ng aspect ratio (macOS 14 issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.