Skip to content

Lint error#4

Open
bstoll wants to merge 19 commits intomainfrom
lint-error
Open

Lint error#4
bstoll wants to merge 19 commits intomainfrom
lint-error

Conversation

@bstoll
Copy link
Copy Markdown
Owner

@bstoll bstoll commented Mar 7, 2025

No description provided.

marcushines and others added 17 commits November 6, 2024 15:47
* update packer

* add bridge
Revise the cloud build scriptwq./third_party/openconfig/kne/internal/copybara.sh
* Update kind to 1.24.0 and node to 1.31.0
also updates kube apis to 1.31

* fix logging

* add node updates

* Update packers to build with new version of kind
* CDNOS: update version, fix published ports

* fix InterfaceCount for mgmt
The version requirement was bumped in 3315c2, resulting in the a build
failure when following the documentation.

Current behaviour:
```
$ kne deploy deploy/kne/kind-bridge.yaml
I0105 09:09:28.147208   67772 deploy.go:195] Deploying cluster...
Error: failed to deploy cluster: failed to check for dependencies: kind version check failed: got 0.19.0, want 0.24.0. install with `go install sigs.k8s.io/kind@0.24.0`
```

New behaviour:
```
$ kne deploy deploy/kne/kind-bridge.yaml
I0105 09:13:48.483372   71859 deploy.go:195] Deploying cluster...
I0105 09:13:48.498972   71859 deploy.go:619] kind version valid: got 0.24.0 want 0.24.0
```
The downloaded branch & all other links, reference `main`.

Move the topo.proto links to also use `main` for consistency.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 7, 2025

Pull Request Test Coverage Report for Build 13727402672

Details

  • 7 of 11 (63.64%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-17.4%) to 46.197%

Changes Missing Coverage Covered Lines Changed/Added Lines %
deploy/deploy.go 1 2 50.0%
topo/node/arista/arista.go 0 1 0.0%
topo/node/drivenets/drivenets.go 6 7 85.71%
x/wire/forward/main.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
topo/node/arista/arista.go 2 70.8%
Totals Coverage Status
Change from base Build 11708724957: -17.4%
Covered Lines: 5491
Relevant Lines: 11886

💛 - Coveralls

This reverts commit fa1f6af.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants