Allow overriding version/appversion on when oci registry is enabled by tuxillo · Pull Request #29 · bsord/helm-push

tuxillo · 2023-03-21T10:03:07Z

When enabling the OCI registry, it is not possible to override Helm chart's version and appversion. With this change it is made possible.

almereyda · 2023-03-29T18:03:08Z

entrypoint.sh

 fi

-if [ "$UPDATE_DEPENDENCIES" == "1" ] || [ "$UPDATE_DEPENDENCIES" == "True" ] || [ "$UPDATE_DEPENDENCIES" == "TRUE" ] || [ "$UPDATE_DEPENDENCIES" == "true" ]; then
+if [ "$UPDATE_DEPENDENCIES" == "1" ] || [[ "$UPDATE_DEPENDENCIES" == [Tt][Rr][Uu][Ee] ]]; then


almereyda · 2023-03-29T18:04:11Z

With this change it is made possible.

Can this statement be validated with a test, or with an exemplary run in a public repository?

tuxillo · 2023-03-30T07:49:48Z

With this change it is made possible.

Can this statement be validated with a test, or with an exemplary run in a public repository?

I don't have any exemplary run in public repos, only in private ones. We could add some test for this, I guess, what do you suggest?

almereyda · 2023-03-30T12:45:00Z

I'm not yet a user of helm-push, and have no environment set up right now. Unfortunately the GitHub Actions documentation also doesn't mention examples on how to test a GitHub action sufficiently. The only reference I could find was:

https://github.com/Azure/actions/blob/main/docs/Testing-docs/Testing-GitHub-Actions.md

But in the important sections it also says "Details to be added".

Maybe a screenshot will be enough to show that this works as intended, without causing any unintended side-effects?

Or it may be possible to run helm-push through a shim like https://github.com/nektos/act, and validate it in such an environment, locally?

josemartins88 · 2023-03-30T15:31:42Z

🥇

tuxillo · 2023-03-30T18:43:50Z

Very nice recommendation @almereyda, thanks!

Given this workflow:

# Run when there are changes to a PR that is ready to review
name: pr

on:
  pull_request:
    types: [opened]
    branches: ["main"]

jobs:
  do_pr:
    runs-on: [ubuntu-latest]
    steps:
      - name: Checkout code
        uses: actions/checkout@v3
      - name: Push Helm with BSORD
        uses: bsord/helm-push@master
        with:
          useOCIRegistry: true
          registry-url: oci://ghcr.io/tuxillo/helm-push
          username: tuxillo
          access-token: ${{ secrets.GITHUB_TOKEN }}
          force: true
          version: 1.2.3
          appVersion: 1.2.3
          chart-folder: charts/test-chart
      - name: Push Helm with TUXILLO
        uses: tuxillo/helm-push@fix-override-versions
        with:
          useOCIRegistry: true
          registry-url: oci://ghcr.io/tuxillo/helm-push
          username: tuxillo
          access-token: ${{ secrets.GITHUB_TOKEN }}
          force: true
          version: 1.2.3
          appVersion: 1.2.3
          chart-folder: charts/test-chart

I get the following output:

[pr/do_pr] 🚀  Start image=catthehacker/ubuntu:act-latest
[pr/do_pr]   🐳  docker pull image=catthehacker/ubuntu:act-latest platform=linux/amd64 username= forcePull=true
[pr/do_pr]   🐳  docker create image=catthehacker/ubuntu:act-latest platform=linux/amd64 entrypoint=["tail" "-f" "/dev/null"] cmd=[]
[pr/do_pr]   🐳  docker run image=catthehacker/ubuntu:act-latest platform=linux/amd64 entrypoint=["tail" "-f" "/dev/null"] cmd=[]
[pr/do_pr]   ☁  git clone 'https://github.com/bsord/helm-push' # ref=master
[pr/do_pr]   ☁  git clone 'https://github.com/tuxillo/helm-push' # ref=fix-override-versions
[pr/do_pr] ⭐ Run Main Checkout code
[pr/do_pr]   🐳  docker cp src=/Users/antonioh/temp/helm/. dst=/Users/antonioh/temp/helm
[pr/do_pr]   ✅  Success - Main Checkout code
[pr/do_pr] ⭐ Run Main Push Helm with BSORD
[pr/do_pr]   🐳  docker build -t act-bsord-helm-push-master-dockeraction:latest --platform linux/amd64 /Users/antonioh/.cache/act/bsord-helm-push@master/
[pr/do_pr]   🐳  docker pull image=act-bsord-helm-push-master-dockeraction:latest platform=linux/amd64 username= forcePull=false
[pr/do_pr]   🐳  docker create image=act-bsord-helm-push-master-dockeraction:latest platform=linux/amd64 entrypoint=[] cmd=[]
[pr/do_pr]   🐳  docker run image=act-bsord-helm-push-master-dockeraction:latest platform=linux/amd64 entrypoint=[] cmd=[]
| OCI SPECIFIED, USING HELM OCI FEATURES
| Login Succeeded
| Packaging chart 'charts/test-chart'
| Successfully packaged chart and saved it to: /Users/antonioh/temp/helm/test-chart-0.1.0.tgz
| Pushing chart test-chart-0.1.0.tgz to 'oci://ghcr.io/tuxillo/helm-push'
| Pushed: ghcr.io/tuxillo/helm-push/test-chart:0.1.0
| Digest: sha256:14b5bccc0e0ea70985c1ee391a0f751e0107e5bdcbd820cd5c058ed335af59be
| Successfully pushed chart test-chart-0.1.0.tgz to 'oci://ghcr.io/tuxillo/helm-push'
[pr/do_pr]   ✅  Success - Main Push Helm with BSORD
[pr/do_pr] ⭐ Run Main Push Helm with TUXILLO
[pr/do_pr]   🐳  docker build -t act-tuxillo-helm-push-fix-override-versions-dockeraction:latest --platform linux/amd64 /Users/antonioh/.cache/act/tuxillo-helm-push@fix-override-versions/
[pr/do_pr]   🐳  docker pull image=act-tuxillo-helm-push-fix-override-versions-dockeraction:latest platform=linux/amd64 username= forcePull=false
[pr/do_pr]   🐳  docker create image=act-tuxillo-helm-push-fix-override-versions-dockeraction:latest platform=linux/amd64 entrypoint=[] cmd=[]
[pr/do_pr]   🐳  docker run image=act-tuxillo-helm-push-fix-override-versions-dockeraction:latest platform=linux/amd64 entrypoint=[] cmd=[]
| Version is defined, using as parameter.
| App version is defined, using as parameter.
| OCI SPECIFIED, USING HELM OCI FEATURES
| Login Succeeded
| Packaging chart 'charts/test-chart'
| Successfully packaged chart and saved it to: /Users/antonioh/temp/helm/test-chart-1.2.3.tgz
| Pushing chart test-chart-1.2.3.tgz to 'oci://ghcr.io/tuxillo/helm-push'
| Pushed: ghcr.io/tuxillo/helm-push/test-chart:1.2.3
| Digest: sha256:84869c128f633c3df84d3faaa81977330cc74633af759c235316a578880e6a96
| Successfully pushed chart test-chart-1.2.3.tgz to 'oci://ghcr.io/tuxillo/helm-push'
[pr/do_pr]   ✅  Success - Main Push Helm with TUXILLO
[pr/do_pr] 🏁  Job succeeded

almereyda · 2023-03-31T13:22:50Z

What happens when you don't specify version and/or appVersion?

Would you like to add that case, too?

Let's just make sure this doesn't break existing user's workflows.

tuxillo · 2023-04-03T16:16:34Z

Workflow:

# Run when there are changes to a PR that is ready to review
name: pr

on:
  pull_request:
    types: [opened]
    branches: ["main"]

jobs:
  do_pr:
    runs-on: [ubuntu-latest]
    steps:
      - name: Checkout code
        uses: actions/checkout@v3
      - name: Push Helm with BSORD
        uses: bsord/helm-push@master
        with:
          useOCIRegistry: true
          registry-url: oci://ghcr.io/tuxillo/helm-push
          username: tuxillo
          access-token: ${{ secrets.GITHUB_TOKEN }}
          force: true
          version: 1.2.3
          appVersion: 1.2.3
          chart-folder: charts/test-chart
      - name: Push Helm with TUXILLO
        uses: tuxillo/helm-push@fix-override-versions
        with:
          useOCIRegistry: true
          registry-url: oci://ghcr.io/tuxillo/helm-push
          username: tuxillo
          access-token: ${{ secrets.GITHUB_TOKEN }}
          force: true
          version: 1.2.3
          appVersion: 1.2.3
          chart-folder: charts/test-chart
      - name: Push Helm with TUXILLO no versions
        uses: tuxillo/helm-push@fix-override-versions
        with:
          useOCIRegistry: true
          registry-url: oci://ghcr.io/tuxillo/helm-push
          username: tuxillo
          access-token: ${{ secrets.GITHUB_TOKEN }}
          force: true
          chart-folder: charts/test-chart

Result:

WARN  ⚠ You are using Apple M1 chip and you have not specified container architecture, you might encounter issues while running act. If so, try running it with '--container-architecture linux/amd64'. ⚠
[pr/do_pr] 🚀  Start image=catthehacker/ubuntu:act-latest
[pr/do_pr]   🐳  docker pull image=catthehacker/ubuntu:act-latest platform= username= forcePull=true
[pr/do_pr]   🐳  docker create image=catthehacker/ubuntu:act-latest platform= entrypoint=["tail" "-f" "/dev/null"] cmd=[]
[pr/do_pr]   🐳  docker run image=catthehacker/ubuntu:act-latest platform= entrypoint=["tail" "-f" "/dev/null"] cmd=[]
[pr/do_pr]   ☁  git clone 'https://github.com/bsord/helm-push' # ref=master
[pr/do_pr]   ☁  git clone 'https://github.com/tuxillo/helm-push' # ref=fix-override-versions
[pr/do_pr]   ☁  git clone 'https://github.com/tuxillo/helm-push' # ref=fix-override-versions
[pr/do_pr] ⭐ Run Main Checkout code
[pr/do_pr]   🐳  docker cp src=/Users/antonioh/temp/helm/. dst=/Users/antonioh/temp/helm
[pr/do_pr]   ✅  Success - Main Checkout code
[pr/do_pr] ⭐ Run Main Push Helm with BSORD
[pr/do_pr]   🐳  docker build -t act-bsord-helm-push-master-dockeraction:latest /Users/antonioh/.cache/act/bsord-helm-push@master/
[pr/do_pr]   🐳  docker pull image=act-bsord-helm-push-master-dockeraction:latest platform= username= forcePull=false
[pr/do_pr]   🐳  docker create image=act-bsord-helm-push-master-dockeraction:latest platform= entrypoint=[] cmd=[]
[pr/do_pr]   🐳  docker run image=act-bsord-helm-push-master-dockeraction:latest platform= entrypoint=[] cmd=[]
| OCI SPECIFIED, USING HELM OCI FEATURES
| Login Succeeded
| Packaging chart 'charts/test-chart'
| Successfully packaged chart and saved it to: /Users/antonioh/temp/helm/test-chart-0.1.0.tgz
| Pushing chart test-chart-0.1.0.tgz to 'oci://ghcr.io/tuxillo/helm-push'
| Pushed: ghcr.io/tuxillo/helm-push/test-chart:0.1.0
| Digest: sha256:29dc0a769fdb8f03d59567a5dc3e50b0fa5cc64174a53b5a2143ca2d68348bbe
| Successfully pushed chart test-chart-0.1.0.tgz to 'oci://ghcr.io/tuxillo/helm-push'
[pr/do_pr]   ✅  Success - Main Push Helm with BSORD
[pr/do_pr] ⭐ Run Main Push Helm with TUXILLO
[pr/do_pr]   🐳  docker build -t act-tuxillo-helm-push-fix-override-versions-dockeraction:latest /Users/antonioh/.cache/act/tuxillo-helm-push@fix-override-versions/
[pr/do_pr]   🐳  docker pull image=act-tuxillo-helm-push-fix-override-versions-dockeraction:latest platform= username= forcePull=false
[pr/do_pr]   🐳  docker create image=act-tuxillo-helm-push-fix-override-versions-dockeraction:latest platform= entrypoint=[] cmd=[]
[pr/do_pr]   🐳  docker run image=act-tuxillo-helm-push-fix-override-versions-dockeraction:latest platform= entrypoint=[] cmd=[]
| Version is defined, using as parameter.
| App version is defined, using as parameter.
| OCI SPECIFIED, USING HELM OCI FEATURES
| Login Succeeded
| Packaging chart 'charts/test-chart'
| Successfully packaged chart and saved it to: /Users/antonioh/temp/helm/test-chart-1.2.3.tgz
| Pushing chart test-chart-1.2.3.tgz to 'oci://ghcr.io/tuxillo/helm-push'
| Pushed: ghcr.io/tuxillo/helm-push/test-chart:1.2.3
| Digest: sha256:2c781d449f42a7a910a6eec0fd866f2e16dee16e8cdb45a87e92a2f058e3d514
| Successfully pushed chart test-chart-1.2.3.tgz to 'oci://ghcr.io/tuxillo/helm-push'
[pr/do_pr]   ✅  Success - Main Push Helm with TUXILLO
[pr/do_pr] ⭐ Run Main Push Helm with TUXILLO no versions
[pr/do_pr]   🐳  docker build -t act-tuxillo-helm-push-fix-override-versions-dockeraction:latest /Users/antonioh/.cache/act/tuxillo-helm-push@fix-override-versions/
[pr/do_pr]   🐳  docker pull image=act-tuxillo-helm-push-fix-override-versions-dockeraction:latest platform= username= forcePull=false
[pr/do_pr]   🐳  docker create image=act-tuxillo-helm-push-fix-override-versions-dockeraction:latest platform= entrypoint=[] cmd=[]
[pr/do_pr]   🐳  docker run image=act-tuxillo-helm-push-fix-override-versions-dockeraction:latest platform= entrypoint=[] cmd=[]
| OCI SPECIFIED, USING HELM OCI FEATURES
| Login Succeeded
| Packaging chart 'charts/test-chart'
| Successfully packaged chart and saved it to: /Users/antonioh/temp/helm/test-chart-0.1.0.tgz
| Pushing chart test-chart-0.1.0.tgz to 'oci://ghcr.io/tuxillo/helm-push'
| Pushed: ghcr.io/tuxillo/helm-push/test-chart:0.1.0
| Digest: sha256:88dc7599edda61365d7cedbb20ab8e7996be6db7fc6590b8558b920c19a2ea17
| Successfully pushed chart test-chart-0.1.0.tgz to 'oci://ghcr.io/tuxillo/helm-push'
[pr/do_pr]   ✅  Success - Main Push Helm with TUXILLO no versions

tuxillo · 2023-04-18T08:40:15Z

Anything else required?

tuxillo · 2023-07-08T09:19:08Z

Can we have this integrated? 😃

tuxillo · 2023-09-16T09:49:05Z

Any chance this can be merged?

bscholtes1A · 2023-09-30T15:51:52Z

@bsord Could someone please take care of merging this PR?

bsord · 2023-10-01T00:29:47Z

Sure! Let me get it tested. Anyone interested in becoming a maintainer, please let me know. Happy to have others on board to keep this moving.

…

On Sat, Sep 30, 2023, 10:52 AM Benjamin Scholtes ***@***.***> wrote: @bsord <https://github.com/bsord> Could someone take care of merging this PR? — Reply to this email directly, view it on GitHub <#29 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEKBZBUKLCFUBHEIONJHSXLX5A52HANCNFSM6AAAAAAWCGNNFA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

fredleger · 2023-10-04T08:48:08Z

@bsord happy to help you reviewing PRs if you still want maintainers

tuxillo · 2024-02-01T17:12:49Z

folks, any news?

tuxillo · 2025-02-06T19:38:42Z

whatever happened to this one 😄

josemartins88 · 2025-02-06T23:33:01Z

Please, let's get this merged !

Allow overriding version/appversion on when oci registry is enabled

b173c4b

almereyda reviewed Mar 29, 2023

View reviewed changes

Conversation

tuxillo commented Mar 21, 2023

Uh oh!

almereyda Mar 29, 2023

Choose a reason for hiding this comment

Uh oh!

almereyda commented Mar 29, 2023

Uh oh!

tuxillo commented Mar 30, 2023

Uh oh!

almereyda commented Mar 30, 2023

Uh oh!

josemartins88 commented Mar 30, 2023

Uh oh!

tuxillo commented Mar 30, 2023

Uh oh!

almereyda commented Mar 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tuxillo commented Apr 3, 2023

Uh oh!

tuxillo commented Apr 18, 2023

Uh oh!

tuxillo commented Jul 8, 2023

Uh oh!

tuxillo commented Sep 16, 2023

Uh oh!

bscholtes1A commented Sep 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bsord commented Oct 1, 2023 via email

Uh oh!

fredleger commented Oct 4, 2023

Uh oh!

tuxillo commented Feb 1, 2024

Uh oh!

tuxillo commented Feb 6, 2025

Uh oh!

josemartins88 commented Feb 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

almereyda commented Mar 31, 2023 •

edited

Loading

bscholtes1A commented Sep 30, 2023 •

edited

Loading