fix: software_stack instead correctly assume to be a dictionary inste…#4
Open
jaydrennan wants to merge 1 commit intomasterfrom
Open
fix: software_stack instead correctly assume to be a dictionary inste…#4jaydrennan wants to merge 1 commit intomasterfrom
jaydrennan wants to merge 1 commit intomasterfrom
Conversation
…ad of SoftwareStock object
Collaborator
Author
|
So I printed the software_stack here and it was actually a dict with slightly different attributes. Looked into changing this to be SoftwareStack object but it seemed to cause other issues. You can see in generate_software_project_plan.py under the generate_software_stack() that it returns a dict instead of the SoftwareStack object. Now that I'm writing this out I'm guessing you'll suggest it would be better to make it use the object. |
Collaborator
Author
|
Well I must have broke more than I fixed. Python files generated are empty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ad of SoftwareStock object