Changed url for moveBookmark#1
Open
arthurnoerve wants to merge 2 commits intobryantchan:masterfrom
arthurnoerve:master
Open
Changed url for moveBookmark#1arthurnoerve wants to merge 2 commits intobryantchan:masterfrom arthurnoerve:master
arthurnoerve wants to merge 2 commits intobryantchan:masterfrom
arthurnoerve:master
Conversation
Used the api to move bookmarks, at the time it just unarchived them. Checked source and found an incorrect url.
I just changed the file directly, given the small edit it's ok. Used the api to move bookmarks, at the time it just unarchived them. Checked source and found an incorrect url.
Repository owner
deleted a comment from
mkproject-admin
Feb 21, 2024
Repository owner
deleted a comment from
fede-s
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edited index.js/.coffee so that the moveBookmark method actually does what it's supposed to; the url wasn't correct. I couldn't figure out why my bookmarks kept leaping back to the inbox...