Reproduce results from original paper in EBMC example #8
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a reproduction of results from the original EBMC (Edge-weighted Budgeted Maximum Coverage) paper, specifically targeting Table 7 of the preprint. The changes focus on computing Optimal Social Welfare (OSW) and Price of Stability (POS) for the Selfish Game Model (SGM).
- Adds new test case to validate EBMC example results against paper benchmarks
- Refactors profile support/probability calculations into separate functions for better modularity
- Enhances EBMC example with social welfare computation and POS calculation
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/examples.jl | Adds test case that downloads EBMC dataset and validates POS >= 1.0 constraint |
| src/Game/Profile.jl | Extracts support and probabilities functions from expected_value for reusability |
| examples/ebmc.jl | Major enhancement adding social welfare model, POS computation, and paper reproduction functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
Specifically targeting Table 7 of the preprint. Focus on computing OSW and POS for SGM.