Merged
Conversation
The format of `t.Errorf()` is something like `file.go:69: message`, so if we use lower case for the message, we might miss the error message. Let's try using capitalization at the beginning of the message and see how it goes.
Make the filename scheme consistent using underscore instead of dash.
This is so that we can debug the generated json file in test by replacing the temporary directory with `/tmp`.
This is so that i can use it separately from TestSetupStatusFile(). Sometimes i need to test the scenario where the status file is not exist yet and need to reset the file state so that we can reuse the file.
The cleanup function is called in "last added, first called" order, so let's put it before looping cases to make sure that it's called last.
…tion" This reverts commit 2df4d63.
Test whether the end time result correct or not.
Test whether `is_notify` is true or false depending on input use notify and notify command exist.
Feels like we don't need to create test for reset functionality as it's basically only deleting the status file.
Test the status indicator when we have pause point in status file.
To make sure that the pipeline get triggered in new commit (?). Let's see how it goes.
Let's see if this changes can fix the failed test.
Let's see if using `Compare()` actually solve the failing test on github CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding test case for existing subcommands.