Open
Conversation
…r AMD compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18
Fixes #8
I have have set the frame buffer dimensions when they get created. For me this was the main reason why the hook did not draw with AMD cards. With NVIDIA cards I did not have an issue.
Also I have set the signal semaphores of the graphics queue to the wait semaphores of
vkQueuePresentKHRpPresentInfo->pWaitSemaphores.This seems to fix the freeze users were experiencing on AMD cards.
My reasoning is, that since the queue waits on
pPresentInfo->pWaitSemaphoresthey are not in a signaled state after the queue has done its work and so the original call ofvkQueuePresentKHRgets stuck at waiting on them.They need to be signaled again after the queue has done its work and I just let the queue do that itself by setting the queues
info.pSignalSemaphores = pPresentInfo->pWaitSemaphores;I have tested the fix on three different games:
with two different GPUs:
I am open for any discussions.
Cheers!