UI Consistency & Visual Stability Pass Across Hero, Navbar, Badges, Carousel, and Footer#68
Conversation
|
@k4rth1k-h3gd3 is attempting to deploy a commit to the Akash Kumar's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Hi @k4rth1k-h3gd3, Thanks for your contribution and the effort you put into this PR. Sorry for the delayed response. The changes align with the light/dark theme toggle issue, but the proposed solution isn’t quite what we were expecting for implementing light theme support across all pages. I really appreciate the work you’ve put into this. We’re merging the PR into another branch for now. |
|
Hello @akash-kumar-dev, The reason I couldn't fix this for all pages it because the code used your project had so many errors, someone must have done something wrong. There were 3 types of color grading that was used. You can see the PR I sent before this; you have to merge that as well else it won't work. It is #64. |
|
I think I deserve at least a Medium for this issue due to difficulty and messiness of the code present. It took me 2 days to properly plan and manually change everything. Ik this doesn't enable toggles for all pages, but I have made your code proper + added proper functions so that anyone using this code in the future can easily do the additions. Please re-review this PR as well. |
If merging both was necessary, why weren't the changes made in a single branch? Now, those changes have conflicts with your previous branch. |
|
No, they go one after another. I mean first one fixes the code then second one adds the toggle. Issue #64 was the one assigned to me first. So, I sent the PR to that which has to be merged. And that was a Hard issue. So, I think based on the requirements mentioned I have done the task and actually help you optimize your code by minimizing the complex thigs used over and over again, so that it can be easier for the future contributors to work on it and build on top of this code. Hope you understand @akash-kumar-dev.
|
Hello, @akash-kumar-dev.
Description
This PR focuses on systematic UI/UX stabilization and visual consistency across the application.
Following PR 01 (structural UI changes), several critical inconsistencies surfaced, especially around color handling, hover behavior, foreground usage, and component contrast.
This PR does not add new features.
Instead, it fixes deep visual issues that directly impacted readability, accessibility, and perceived polish in both light and dark environments.
The changes were intentionally separated from PR 01 to keep review scope clean and focused.
Type of Change
Related Issue
Changes Made
Testing Done
Please describe how you tested your changes:
npm run dev)npm run build && npm start)npm run lint)Screenshots (if applicable)
Before:
BP.PR2.Before.mp4
After:
BP.PR2.After.mp4
Checklist
IMPORTANT: Please ensure all items are checked before submitting. PRs that don't follow these guidelines may be closed.
Additional Notes
This PR intentionally follows PR 01 instead of extending it.
PR 01 focused on layout and structure.
This PR addresses visual correctness, polish, and user-perceived quality, which required focused iteration and careful tuning.
Reviewing these changes separately should make validation faster and clearer.
I have ensured that all the visibility and features are properly visible and properly present for both the modes. I have also optimized the code and removed the unnecessary multiple color combinations used and it makes the entire website function normally with all the things working properly.
Please review this thoroughly and tell me if there are any errors or changes, I have to make. If so, I will work on them and make them proper.
If not, please assign the required tags for this. Based on the effort and time this entire thing took, I think this PR deserves HArd tag. Just a suggestion from my side.
Thank you!!
Remember: Quality over quantity. A well-tested, properly documented small PR is better than a large, rushed contribution.
For more details, please refer to our [Contributing Guidelines] (CONTRIBUTING.md).