New pull request made without force push#60
Conversation
|
@Parwathi-Jayaram is attempting to deploy a commit to the Akash Kumar's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@akash-kumar-dev I have created a new pull request this time so please check that out. I am also closing the old PR. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Updates the home page Features carousel auto-scroll behavior and refreshes a few NPM lockfile entries.
Changes:
- Refactors
FeaturesSectionauto-scroll into a restartable interval (and updates the delay to 10s). - Resets auto-scroll when users manually navigate (next/prev/dots).
- Updates
package-lock.jsondependency resolutions (e.g.,js-yaml,tar) and aligns the recorded TypeScript spec withpackage.json.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/components/home/FeaturesSection.tsx |
Refactors carousel auto-scroll interval management and resets it on manual navigation. |
package-lock.json |
Updates lockfile metadata and some resolved transitive dependency versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| intervalRef.current = setInterval(() => { | ||
| setCurrentIndex((prev) => (prev + 1) % features.length); | ||
| }; | ||
| }, 10000); | ||
| }, [features.length]); |
There was a problem hiding this comment.
This change introduces new auto-scroll timing/reset behavior (clearing/restarting an interval on navigation). Please add/extend a Vitest + Testing Library test that uses fake timers to assert (1) the slide advances after the configured interval and (2) clicking next/prev resets the timer so multiple intervals don’t accumulate.
|
Please address the formatting issues suggested by Copilot. After that, the PR looks good to merge. |
|
okie @akash-kumar-dev I will do that |
|
@akash-kumar-dev pls check it out |
|
Have fixed the remaining code formatting issues, and everything looks good now. Thanks for your contribution! Join our Discord server: https://discord.gg/Gtv9PFgaHZ |
2 participants
Description
I have created a new pull request without using force push in a new branch.
Type of Change
Related Issue
Closes #44
Testing Done
Please describe how you tested your changes:
npm run dev)npm run build && npm start)npm run lint)Screenshots (if applicable)
Checklist
IMPORTANT: Please ensure all items are checked before submitting. PRs that don't follow these guidelines may be closed.
Additional Notes
Any additional information that would be helpful for reviewers?
Remember: Quality over quantity. A well-tested, properly documented small PR is better than a large, rushed contribution.
For more details, please refer to our Contributing Guidelines.