Fix for timers showing wrong initial duration#66
Merged
brownard merged 1 commit intobrownard:masterfrom Mar 11, 2026
Merged
Conversation
xvello
force-pushed
the
xvello/timer-fix
branch
from
6d8d580 to
c54530c
Compare
Owner
|
Thanks, I had noticed that issue! Are you happy to merge this? |
Contributor
Author
|
Yup, fell free to squash-and-merge any of my PR after review. If they're not really I'll open them as draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
v0.5.0, the first timer is displayed with the right duration, but any subsequent timers are first shown with a wrong duration, that is fixed after one second.LaunchedEffectto updatenowas soon as possible: it is useless for the first timer, but needed for subsequent creations (currently, the timer is initially shown with a duration computed with an outdatednow)Unit, as the effect does not need to be re-created if thetimerslist changes