Skip to content

[projmgr] Test OutputDirsAbsolutePath #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brondani wants to merge 1 commit into from
Closed

[projmgr] Test OutputDirsAbsolutePath #19

brondani wants to merge 1 commit into from

Conversation

@brondani
Copy link
Owner

@brondani brondani commented May 14, 2025

@github-actions
Copy link

github-actions bot commented May 14, 2025 •
edited
Loading

Test Results

  7 files   53 suites   4m 45s ⏱️
185 tests 168 ✅ 17 💤 0 ❌
692 runs  624 ✅ 68 💤 0 ❌

Results for commit 8f6da04.

♻️ This comment has been updated with latest results.

github-advanced-security[bot]
github-advanced-security bot found potential problems May 14, 2025
View reviewed changes
tools/projmgr/test/src/ProjMgrUnitTests.cpp

TEST_F(ProjMgrUnitTests, OutputDirsAbsolutePath) {
StdStreamRedirect streamRedirect;
//StdStreamRedirect streamRedirect;

Check notice

Code scanning / CodeQL

Commented-out code Note test

This comment appears to contain commented-out code.

Copilot Autofix

AI 8 months ago

The best way to fix the problem is to remove the commented-out line entirely. This will eliminate the distraction and potential confusion caused by the presence of commented-out code. If the line is needed later, it can be retrieved from the version control system.

Suggested changeset 1
tools/projmgr/test/src/ProjMgrUnitTests.cpp

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/tools/projmgr/test/src/ProjMgrUnitTests.cpp b/tools/projmgr/test/src/ProjMgrUnitTests.cpp
--- a/tools/projmgr/test/src/ProjMgrUnitTests.cpp
+++ b/tools/projmgr/test/src/ProjMgrUnitTests.cpp
@@ -4121,3 +4121,2 @@
 TEST_F(ProjMgrUnitTests, OutputDirsAbsolutePath) {
-  //StdStreamRedirect streamRedirect;
   char* argv[5];
EOF
@@ -4121,3 +4121,2 @@
TEST_F(ProjMgrUnitTests, OutputDirsAbsolutePath) {
//StdStreamRedirect streamRedirect;
char* argv[5];
Copilot is powered by AI and may make mistakes. Always verify output.
tools/projmgr/test/src/ProjMgrUnitTests.cpp
Comment on lines +4131 to +4132
//auto errStr = streamRedirect.GetErrorString();
//EXPECT_TRUE(regex_search(errStr, regex("warning csolution: absolute path .* is not portable, use relative path instead")));

Check notice

Code scanning / CodeQL

Commented-out code Note test

This comment appears to contain commented-out code.

Copilot Autofix

AI 8 months ago

To fix the issue, we need to either remove the commented-out code or reinstate it. Since the commented-out code appears to be part of a test case, it is likely intended to verify specific behavior. Therefore, the best approach is to reinstate the code and ensure it is functional. If the code is no longer needed, it should be removed entirely. In this case, we will reinstate the code to maintain the integrity of the test.

Suggested changeset 1
tools/projmgr/test/src/ProjMgrUnitTests.cpp

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/tools/projmgr/test/src/ProjMgrUnitTests.cpp b/tools/projmgr/test/src/ProjMgrUnitTests.cpp
--- a/tools/projmgr/test/src/ProjMgrUnitTests.cpp
+++ b/tools/projmgr/test/src/ProjMgrUnitTests.cpp
@@ -4130,4 +4130,4 @@
 
-  //auto errStr = streamRedirect.GetErrorString();
-  //EXPECT_TRUE(regex_search(errStr, regex("warning csolution: absolute path .* is not portable, use relative path instead")));
+  auto errStr = streamRedirect.GetErrorString();
+  EXPECT_TRUE(regex_search(errStr, regex("warning csolution: absolute path .* is not portable, use relative path instead")));
 }
EOF
@@ -4130,4 +4130,4 @@

//auto errStr = streamRedirect.GetErrorString();
//EXPECT_TRUE(regex_search(errStr, regex("warning csolution: absolute path .* is not portable, use relative path instead")));
auto errStr = streamRedirect.GetErrorString();
EXPECT_TRUE(regex_search(errStr, regex("warning csolution: absolute path .* is not portable, use relative path instead")));
}
Copilot is powered by AI and may make mistakes. Always verify output.
@brondani brondani force-pushed the projmgr-check-testcase branch 2 times, most recently from e930e74 to 0f876d0 Compare May 14, 2025 10:07
@brondani brondani force-pushed the projmgr-check-testcase branch from 0f876d0 to 8f6da04 Compare May 14, 2025 10:45
@brondani brondani closed this May 14, 2025
@brondani brondani deleted the projmgr-check-testcase branch May 14, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brondani