Replace anchor tags with Router.Link for client-side navigation#12
Merged
Replace anchor tags with Router.Link for client-side navigation#12
Conversation
Set Router.init basePath to "/rescript-signals" so the router correctly strips and adds the base path for GitHub Pages deployment. Convert raw <a href> links to Router.Link in App, Breadcrumbs, and PageNavigation so all internal navigation goes through the router and gets the base path prefix automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the documentation website to use the
Router.Linkcomponent instead of standard HTML anchor tags (<a>) for internal navigation. This enables client-side routing instead of full page reloads, improving the user experience. Additionally, the Router is initialized with a base path to support deployment in a subdirectory.Key Changes
<a>tags with<Router.Link>for previous/next page navigation links<a>tags with<Router.Link>for logo and header navigation links<a>tags with<Router.Link>for breadcrumb navigation linksRouter.init()call to include~basePath="/rescript-signals"parameter for proper routing in subdirectory deploymentImplementation Details
hrefattributes were converted totoattributes to match theRouter.LinkAPIhttps://claude.ai/code/session_01Rjq6HzjqRpM3dy846r1Vmj