fix: Disable the error page being displayed on navigation errors #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caneraltinbasak
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This change makes the same change used in QtWebEngine to stop being automatically re-directed to the error page
chrome-error://chromewebdata/. It does this by calling NavigationRequest::SetSilentlyIgnoreErrors from WebContents::DidStartNavigation.It was found that some of the Electron tests, that aren't related to testing load failures, rely on being re-directed chrome-error://chromewebdata/. I have modified these tests to open a real blank page instead, which is better practise and fixes the failures.
Checklist
npm testpassesRelease Notes
Notes: