Skip to content

Conversation

@t-bashir-bs
Copy link

@t-bashir-bs t-bashir-bs commented Dec 15, 2025

Description of Change

This PR adds support for Media Source Extensions (MSE) to the Brightsign video player in Chromium. The changes have been ported from the implementation made for QtWebEngine for Brightsign devices.

  1. PumpData:
    Calls are made to ChunkDemuxerStream::Read when the demuxer is not initialized yet, in the older Chromium this was just ignored with NOTREACHED, but in the newer version NOTREACHED_NORETURN gets called which
    crashes the renderer. We now check if the demuxer is initialized before calling ChunkDemuxerStream::Read.

  2. OnDemuxInitialized:
    The first_party_url was used in Chromium 87 but in Chromium 120 we don't have
    this and so like non-mse playback use the representative_url with the top_frame_origin.

Verified using:

  1. Bitmovin MSE-demo
  2. Vimeo
  3. YouTube
  4. Carson MSE conformance test

Checklist

Release Notes

Notes:

@t-bashir-bs t-bashir-bs force-pushed the tbashir/28-x-y-bs-add-mse-support-OS-19598 branch from 33a5dc0 to db2f3d9 Compare December 15, 2025 14:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@t-bashir-bs t-bashir-bs requested a review from Copilot December 15, 2025 16:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@t-bashir-bs t-bashir-bs requested a review from Copilot December 16, 2025 14:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@t-bashir-bs t-bashir-bs merged commit 0a1966f into 28-x-y-bs Dec 16, 2025
25 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants