-
Notifications
You must be signed in to change notification settings - Fork 3
feat(PE-852): Create autorun.zip example #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds a comprehensive collection of BrightSign example applications to the dev-cookbook repository, significantly expanding beyond the stated scope of just creating an autorun.zip example (PE-852).
Key additions:
- Complete autorun.zip package example with build tooling and Partner Gallery integration documentation
- Provisioning server example with Docker deployment
- Multiple deployment, storage, and device integration examples
Reviewed changes
Copilot reviewed 25 out of 75 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Changed workspaces from wildcard pattern to explicit list of 13 example paths |
| examples/autorun-zip-package/* | New comprehensive autorun.zip example with build script, documentation, and setup files |
| examples/provisioning-server/* | New Docker-based provisioning server implementing BrightSign protocol |
| examples/self-signed-certs/* | New example for handling self-signed certificates with BrightSign players |
| examples/node-starter/* | New minimal Node.js HTTP server example |
| examples/node-simple-server/* | New advanced Node.js server with tests and webpack |
| examples/local-storage/* | New image slideshow with localStorage caching |
| examples/indexeddb-caching/* | New video caching example using IndexedDB |
| examples/htmlwidget-iframes/* | New example for trusted iframes configuration |
| examples/html-starter/* | New basic HTML application starter |
| examples/enable-ldws/* | New LDWS enablement examples (3 methods) |
| examples/bs-sqlite-db/* | New SQLite database usage example |
| examples/bs-self-updater/* | New TypeScript self-updating application |
| examples/bluetooth-scan/* | New Bluetooth device scanning example |
| examples/README.md | Updated to document all new examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
blshukla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 questions:
- Can we move all the file renames to its own PR and get it merged first?
- Why is the provisioning-server example part of this PR?
I echo these points. At least the provisioning-server example, unless we are fine to be pushing quickly in this case. May be more burden than note to separate and push elsewhere. |
9d094fd to
0b8b0ef
Compare
📝 Description
Adds an autorun.zip example
Issue: Url to JIRA Issue
📋 List of Changes
🧪 Steps to Test
Notes to the Reviewer
📸 Screenshots
✔️ Dev Complete Checklist