Skip to content

test: somehow the external deps are not being correctly installed. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0x2f0 merged 1 commit into from
Jun 13, 2025
Merged

test: somehow the external deps are not being correctly installed. #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@brightsoftware/table",
"version": "0.1.1",
"version": "0.1.2",
"description": "A React table library by bright office system.",
"license": "MIT",
"author": {
Expand Down
10 changes: 3 additions & 7 deletions vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,8 @@ const prependUseClient = () => {
};
};

// Read package.json to get all dependencies
const packageJson = JSON.parse(readFileSync('./package.json', 'utf8'));
const external = [
...Object.keys(packageJson.dependencies || {}),
...Object.keys(packageJson.peerDependencies || {}),
];
// TODO: Some how mark all the dependencies as external to make the bundle smaller
// and make sure they get auto installed with all the package managers

// NOTE: due to some reason vite is not adding the import statement for transpiled css file
// that is why this function(plugin) exists.
Expand Down Expand Up @@ -80,7 +76,7 @@ export default defineConfig({
},

rollupOptions: {
external: external,
external: ["react", "react-dom"],
output: {
preserveModules: true,
entryFileNames: '[name].js',
Expand Down