This repository was archived by the owner on Jun 1, 2022. It is now read-only.
feat(brigade-github-app): add imagePullSecrets #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vdice
commented
Nov 6, 2020
vdice
commented
- Adds support for setting image pull secrets on the ServiceAccount for the Brigade GitHub App gateway, a la add ability to add image pull secrets to service accounts #81
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Contributor
|
LGTM, but also see message I sent you. I think a broader discussion about how to mitigate the impact of rate limiting by Docker Hub or other registries is in order. I would hate to have to address this chart-by-chart or deployment-by-deployment thereof. |
krancour
approved these changes
Nov 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.