Skip to content

Fix evaluation_data_separate global slot type mismatch#22

Merged
realmarcin merged 5 commits intoschema-extendfrom
copilot/sub-pr-19-another-one
Nov 23, 2025
Merged

Fix evaluation_data_separate global slot type mismatch#22
realmarcin merged 5 commits intoschema-extendfrom
copilot/sub-pr-19-another-one

Conversation

Copy link
Contributor

Copilot AI commented Nov 23, 2025

The global slot definition for evaluation_data_separate had type dataSet with multivalued: true, but EvaluationProcedure overrides it to boolean. This type mismatch is confusing and incorrect.

Changes

  • Changed global evaluation_data_separate slot from range: dataSet to range: boolean
  • Removed multivalued: true (inappropriate for boolean)
  • Updated description from "Evaluation/test datasets" to "Whether evaluation data is separate/external"

The slot now matches its actual usage throughout the schema and in existing examples:

quantitative_analysis:
  evaluation_procedure:
    evaluation_data_separate: true  # Already used as boolean

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI self-assigned this Nov 23, 2025
Co-authored-by: realmarcin <4625870+realmarcin@users.noreply.github.com>
Copilot AI changed the title [WIP] Update LinkML schema to add global boolean for evaluation_data_separate Fix evaluation_data_separate global slot type mismatch Nov 23, 2025
Copilot AI requested a review from realmarcin November 23, 2025 06:06
realmarcin and others added 3 commits November 23, 2025 00:18
- Updated Python version from 3.9 to 3.12 in test workflow
- Changed Poetry installation from snok action to pip (firewall workaround)
- Added --no-root flag to all poetry install commands
- Fixed pyproject.toml: poetry.dev-dependencies → poetry.group.dev.dependencies
- Added packages configuration to pyproject.toml
- Updated include paths to match actual structure

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
PyYAML 6.0 doesn't have pre-built wheels for Python 3.12 and fails to build
from source with Cython errors. Updated to PyYAML 6.0.3 which includes
Python 3.12 wheels.

Fixes: AttributeError: cython_sources in PEP517 build

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
greenlet 1.1.2 doesn't have Python 3.12 wheels and fails to build from source
due to incompatibility with Python 3.12's internal C API changes. Updated to
greenlet 3.2.4 which includes Python 3.12 wheels.

Fixes: Build errors with CFrame, exc_type, recursion_depth in Python 3.12

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@realmarcin realmarcin marked this pull request as ready for review November 23, 2025 19:51
@realmarcin realmarcin merged commit 8dc97a9 into schema-extend Nov 23, 2025
1 check passed
@realmarcin realmarcin deleted the copilot/sub-pr-19-another-one branch November 23, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants