Skip to content

Fix training_data_separate and evaluation_data_separate type mismatch#21

Merged
realmarcin merged 5 commits intoschema-extendfrom
copilot/sub-pr-19-again
Nov 23, 2025
Merged

Fix training_data_separate and evaluation_data_separate type mismatch#21
realmarcin merged 5 commits intoschema-extendfrom
copilot/sub-pr-19-again

Conversation

Copy link
Contributor

Copilot AI commented Nov 23, 2025

Global slot definitions for training_data_separate and evaluation_data_separate were incorrectly typed as multivalued: true, range: dataSet, conflicting with their boolean usage in TrainingProcedure and EvaluationProcedure classes.

Changes

  • Changed training_data_separate global slot from multivalued dataSet to boolean
  • Changed evaluation_data_separate global slot from multivalued dataSet to boolean
  • Updated descriptions to reflect their actual purpose as flags rather than dataset collections

Before/After

# Before - global slot definition
training_data_separate:
  description: Training datasets (explicitly separated from evaluation)
  multivalued: true
  range: dataSet

# After - global slot definition
training_data_separate:
  description: Whether training data is separate/external
  range: boolean

The class-level definitions already used range: boolean, so this aligns the global definitions with actual usage.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI self-assigned this Nov 23, 2025
…ally

Co-authored-by: realmarcin <4625870+realmarcin@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on extending LinkML schema for model card coverage Fix training_data_separate and evaluation_data_separate type mismatch Nov 23, 2025
Copilot AI requested a review from realmarcin November 23, 2025 06:01
realmarcin and others added 3 commits November 23, 2025 00:18
- Updated Python version from 3.9 to 3.12 in test workflow
- Changed Poetry installation from snok action to pip (firewall workaround)
- Added --no-root flag to all poetry install commands
- Fixed pyproject.toml: poetry.dev-dependencies → poetry.group.dev.dependencies
- Added packages configuration to pyproject.toml
- Updated include paths to match actual structure

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
PyYAML 6.0 doesn't have pre-built wheels for Python 3.12 and fails to build
from source with Cython errors. Updated to PyYAML 6.0.3 which includes
Python 3.12 wheels.

Fixes: AttributeError: cython_sources in PEP517 build

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
greenlet 1.1.2 doesn't have Python 3.12 wheels and fails to build from source
due to incompatibility with Python 3.12's internal C API changes. Updated to
greenlet 3.2.4 which includes Python 3.12 wheels.

Fixes: Build errors with CFrame, exc_type, recursion_depth in Python 3.12

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@realmarcin realmarcin marked this pull request as ready for review November 23, 2025 19:50
@realmarcin realmarcin merged commit 98604ec into schema-extend Nov 23, 2025
1 check passed
@realmarcin realmarcin deleted the copilot/sub-pr-19-again branch November 23, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants