Skip to content

Fix ORCID field type inconsistency in LinkML schema#20

Merged
realmarcin merged 5 commits intoschema-extendfrom
copilot/sub-pr-19
Nov 23, 2025
Merged

Fix ORCID field type inconsistency in LinkML schema#20
realmarcin merged 5 commits intoschema-extendfrom
copilot/sub-pr-19

Conversation

Copy link
Contributor

Copilot AI commented Nov 23, 2025

The orcid slot had conflicting type definitions: range: string globally but range: uri in the Contributor class slot_usage, causing potential validation issues.

Changes

  • Updated global orcid slot definition from range: string to range: uri (line 399)
  • Aligns with the Contributor class slot_usage and correctly represents ORCID identifiers as URIs
# Before
orcid:
  description: ORCID identifier
  range: string

# After  
orcid:
  description: ORCID identifier
  range: uri

Existing examples already use URI format (https://orcid.org/0000-0002-1234-5678), so no breaking changes.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: realmarcin <4625870+realmarcin@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 23, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • install.python-poetry.org
    • Triggering command: /usr/bin/curl curl -sSL REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update LinkML schema for LBNL model card coverage Fix ORCID field type inconsistency in LinkML schema Nov 23, 2025
Copilot AI requested a review from realmarcin November 23, 2025 06:00
realmarcin and others added 3 commits November 23, 2025 00:18
- Updated Python version from 3.9 to 3.12 in test workflow
- Changed Poetry installation from snok action to pip (firewall workaround)
- Added --no-root flag to all poetry install commands
- Fixed pyproject.toml: poetry.dev-dependencies → poetry.group.dev.dependencies
- Added packages configuration to pyproject.toml
- Updated include paths to match actual structure

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
PyYAML 6.0 doesn't have pre-built wheels for Python 3.12 and fails to build
from source with Cython errors. Updated to PyYAML 6.0.3 which includes
Python 3.12 wheels.

Fixes: AttributeError: cython_sources in PEP517 build

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
greenlet 1.1.2 doesn't have Python 3.12 wheels and fails to build from source
due to incompatibility with Python 3.12's internal C API changes. Updated to
greenlet 3.2.4 which includes Python 3.12 wheels.

Fixes: Build errors with CFrame, exc_type, recursion_depth in Python 3.12

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@realmarcin realmarcin marked this pull request as ready for review November 23, 2025 19:50
@realmarcin realmarcin merged commit 7c2429d into schema-extend Nov 23, 2025
1 check passed
@realmarcin realmarcin deleted the copilot/sub-pr-19 branch November 23, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants