[WIP] Real time wpm and acc#8
Open
Grivel-l wants to merge 14 commits intobriano1905:masterfrom
Grivel-l:master
Open
[WIP] Real time wpm and acc#8Grivel-l wants to merge 14 commits intobriano1905:masterfrom Grivel-l:master
Grivel-l wants to merge 14 commits intobriano1905:masterfrom
Grivel-l:master
Conversation
Owner
|
Hi I appreciate your contribution to the project I ran it on my local machine and it works wonderfully great job! But I'm not sure if want this to replace the current indicator. It's a bit too distracting and I like seeing my previous WPM and ACC. I'm really sorry I can't merge this |
Author
|
Maybe we could add an option to enable the feature ? |
Owner
|
Hi Grivel sorry I shouldn't have closed this pull request my bad. This is my first collaborative project on GitHub. Yes we can definitely make that an optional feature. Could you implement it the same way I did for punctuation option and disabled by default? That would be great :) |
Author
|
No problem, done, you can enable it with |
Owner
|
Thank you for adding the changes but there are a few problem I found:
|
|
Couple of things:
|
SeerLite
added a commit
to SeerLite/typings
that referenced
this pull request
Dec 18, 2020
SeerLite
added a commit
to SeerLite/typings
that referenced
this pull request
Dec 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.