Skip to content

Conversation

@sodabrew
Copy link

@sodabrew sodabrew commented Jun 3, 2014

Recent PRs #25 and #26 failed because rspec 3.0 matches ">= 2.0.0". This PR pins rspec, rake, rake-compiler as needed.

@sodabrew
Copy link
Author

sodabrew commented Jun 3, 2014

Now the builds are broken due to a memory issue.
Also updated .travis.yml to build Ruby 2.0 and 2.1.

@chewi
Copy link
Contributor

chewi commented Jun 3, 2014

The situation is quite confusing but basically I removed a previous memory leak fix. Maybe there really is a memory leak but the fix caused segfaults for me in certain cases. I only use this library in rake tasks so short-term memory leaks aren't a big issue for me.

@brianmario
Copy link
Owner

👍

@brianmario
Copy link
Owner

Er, what I meant by that was - +1 to this change. The memory corruption thing is a separate issue. I really need to figure out what to do with this gem :\

In short, it probably needs to be rewritten or abandoned (I mean, it is now)

@sodabrew
Copy link
Author

sodabrew commented Jun 4, 2014

I remembered that ALLOC_N should be paired with xfree and not ordinary free, and setbzf->buf = NULL` after each free. Now it just doesn't work instead of crashing. Progress!

@chewi
Copy link
Contributor

chewi commented Jun 4, 2014

Thanks for taking the time to look into this, it is appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants