Factorization algorithm computes incorrect result for some large complex graphs.#66
Open
brianguenter wants to merge 5 commits intomainfrom
Open
Factorization algorithm computes incorrect result for some large complex graphs.#66brianguenter wants to merge 5 commits intomainfrom
brianguenter wants to merge 5 commits intomainfrom
Conversation
…lex graphs. Fixes #65 added new_factor_subgraph! to eventually replace factor_subgraph! changed definition of node_value field in Node to have a Union type instead of Any. May help performance.
…lex graphs. Fixes #65 fixed factor_order. Used to sort by times_used first then by subgraph containment. This was based on an incorrect assumption that the times_used of a subgraph was always greater than or equal to the times_used of a containing subgraph. Now sorts by subgraph containment, then by times_used, so contained subgraphs always get factored first.
This was referenced Apr 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65
Factorization can create new factorable subgraphs interior to an existing subgraph. The most general way to solve this problem is to rerun the dominance calculation on each subgraph where this condition is detected and then to recursively factor these subgraphs before factoring the containing subgraph.
This seemed too computationally expensive so I had special case code which appeared to work. But larger graphs tend to also have more complex internal structure which is more likely to give rise to these internal factorable subgraphs. The current code eventually fails as graphs get larger and their structure becomes more convoluted.
This PR will replace the existing algorithm with a dominance recomputation which will be executed only if internal subgraph creation is detected.