-
Notifications
You must be signed in to change notification settings - Fork 45
Allow ruby version 4.0 in gemspec #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
When running this on newer versions of cucumber, we get: I haven't quite figured that one out either. |
|
@briandunn I think this is ready for review. At least, all specs are now passing :) |
|
@obrie I am so excited about this! There is a lot here I've been meaning to get to for a long time. Gonna review and merge soon. Thank you! |
briandunn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
| # step definitions are available on every runtime *and* also ensure Cucumber isn't memoizing the feature files | ||
| # to run. | ||
| # | ||
| # For now, the legacy autoloader is the only option to keep everything working properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am so happy you figured this out! Had me stuck. Also, I think we're gonna phase out cucumber support I don't think many are using it. (do you?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to help 😄
I've never used cucumber myself. I can't think of too many open-source projects I've seen that have used cucumber either. Based on the number of installs of flatware-cucumber, doesn't seem like there are that many folks who use both flatware and cucumber.
|
Thanks for merging this. Can confirm it works just fine on a WIP ruby 4.0 upgrade branch. Release soon? Separately - we also dont need the cucumber support. Just using flatware as parallelizing wrapping around pretty vanilla rspec suite. |
|
@briandunn anything we can do to assist in version release? Would a PR with the version update help? Anything more you want to fit in prior to that? |
|
Getting this when running rubocop locally:
```
❯ be rubocop
rubocop-rake extension supports plugin, specify `plugins: rubocop-rake`
instead of `require: rubocop-rake` in
/Users/brian/src/flatware/.rubocop.yml.
For more information, see
https://docs.rubocop.org/rubocop/plugin_migration_guide.html.
Error: unrecognized cop or department Naming/PredicateMethod found in
.rubocop.yml
Did you mean `Naming/PredicateName`?
```
is there a mismatch between the bundle rubocop and the .rubocop.yml?
…On Wed, Jan 21, 2026 at 11:36 AM Matt Jankowski ***@***.***> wrote:
*mjankowski* left a comment (briandunn/flatware#113)
<#113 (comment)>
@briandunn <https://github.com/briandunn> anything we can do to assist in
version release? Would a PR with the version update help? Anything more you
want to fit in prior to that?
—
Reply to this email directly, view it on GitHub
<#113 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAWY7S5MWT23V3CCEOBZTD4H62J7AVCNFSM6AAAAACP4ENC2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTONZZHE3TQMJVGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
The That said, yes, I think that cop was renamed at some point, so it could be that you are running older rubocop and hitting that error? If you upgrade to latest rubocop (1.82.1) does that go away? |
|
yes thanks. I'll add a version constraint to the Gemfile.
…On Thu, Jan 22, 2026 at 8:36 AM Matt Jankowski ***@***.***> wrote:
*mjankowski* left a comment (briandunn/flatware#113)
<#113 (comment)>
The Gemfile.lock is gitignored ... so I think there isnt really a
specific bundle version?
That said, yes, I think that cop was renamed at some point, so it could be
that you are running older rubocop and hitting that error? If you upgrade
to latest rubocop (1.82.1) does that go away?
—
Reply to this email directly, view it on GitHub
<#113 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAWY7UKKTFQH2H5S5SYJXL4IDN7DAVCNFSM6AAAAACP4ENC2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOOBUG4YTMMJVGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This adds support for Ruby 4.0. Note this is currently broken for flatware-cucumber due to a change in Ruby that was fixed here: cucumber/cucumber-ruby-core#302
Opening this PR to start a discussion around how you want to move forward to address this. We could change the minimum version require for
flatware-cucumber. I haven't spent time thinking through potential alternatives yet. Example of failure: