Bug fix allowing diamond dependencies.#8
Open
saarraz wants to merge 2 commits intobrianchirls:masterfrom
Open
Conversation
The current version would fail if a "diamond" dependency existed, for example:
a.proto:
message A { }
b.proto:
import "a.proto";
message B { }
c.proto:
import "a.proto";
import "b.proto"; --> ERROR: Duplicate message A defined.
The previous code does have a mechanism to avoid this (the 'loaded' object) but it is not passed down to recursive calls into readProto, which is a bug.
Passing it down fixes the problem.
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version would fail if a "diamond" dependency existed, for example:
a.proto:
message A { }
b.proto:
import "a.proto";
message B { }
c.proto:
import "a.proto";
import "b.proto"; --> ERROR: Duplicate message A defined.
The previous code does have a mechanism to avoid this (the 'loaded' object) but it is not passed down to recursive calls into readProto, which is a bug.
Passing it down fixes the problem.