Added switches for each device which allow toggling mining#15
Open
Newlance wants to merge 4 commits intobrianberg:masterfrom
Open
Added switches for each device which allow toggling mining#15Newlance wants to merge 4 commits intobrianberg:masterfrom
Newlance wants to merge 4 commits intobrianberg:masterfrom
Conversation
…ing. very basic, needs testing. * To do: Set switch to reflect the current state on init. (Currently defaults to off after HA reboot.) * Occasionally the custom component fails to load on HA start. Usually fixed by restarting HA. * When switches are toggled occasionally a false error is reported. This could be due to async call. The desired behavior still occurs though.
…(there is a delay for the status to update into Home Assistant) - Added property to switches which contains the last response from the API. This will reflect "Success!" or otherwise the error message that was provided by the API. - Added additional properties 'status' and 'device' to switches.
Newlance
commented
Nov 12, 2021
Author
Newlance
left a comment
There was a problem hiding this comment.
Switches now properly reflect device state (albeit with a delay).
Switches also now have a property that reflect the API response.
|
@brianberg any reason not to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires additional Manage Rigs permission