Skip to content

Conversation

@danvanhorn
Copy link
Collaborator

@danvanhorn danvanhorn commented Sep 22, 2019

i've added delete tank functionality to the ui (by way of the new disabled field in the db) and reduced the number of data requests made on the tank monitoring page to 1. This was a part of editing the tank monitoring fetch so that I could account for disabled tanks, we didn't want to delete them entirely because of batch/tank history reasons.

closes #27
related to brewhops/api#19

@vercel
Copy link

vercel bot commented Sep 22, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://app-git-feat-create-delete-tank-functionality-on-ui.brewhops.now.sh

@codecov
Copy link

codecov bot commented Sep 22, 2019

Codecov Report

Merging #38 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev     #38   +/-   ##
=====================================
  Coverage   37.5%   37.5%           
=====================================
  Files          4       4           
  Lines         72      72           
  Branches      14      14           
=====================================
  Hits          27      27           
  Misses        45      45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f50c224...626368b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants