fixed sf compute tagging for v0 until tags#97
Merged
Conversation
drewmalin
reviewed
Feb 27, 2026
Comment on lines
477
to
479
| case 2: | ||
| // Old format: refID_name (backward compat — cloudCredRefID and stage unknown) | ||
| return "", "", parts[0], parts[1], nil |
Contributor
There was a problem hiding this comment.
Good call, maybe need a TODO here to remove once we clean up the old nodes
|
|
||
| // vCPU count provided by SF Compute. Currently only 8xH100/H200 instance types are | ||
| // available so it's safe to hardcode. | ||
| const sfcVCPU = 112 |
Contributor
There was a problem hiding this comment.
Nitpick but could you move this to the const block around line 16?
Actually might be nice to move the gpuCount there as well...
drewmalin
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.