feat(BREV-2083): Split Byte Sizes into Value and Unit

[drewmalin]

No description provided.

[patelspratik]

the internet says that changing this to
// Deprecated: TODO deprecate in favor of DiskSizeByteValue will actually mark this as deprecated. Though do you actually want to do that, or defer that change?

[drewmalin]

I am a little worried it will blow up our linter but could give it a shot...

[patelspratik]

thoughts on

Suggested change

	var zeroBytes = ByteValue{value: 0, unit: Byte}
	type ByteValue struct {
	// Value is the whole non-negative number of bytes of the specified unit
	value uint32
	// Unit is the unit of the byte value
	unit ByteUnit
	}
	func NewByteValue(value int32, unit ByteUnit) ByteValue {
	if value < 0 {
	return zeroBytes
	}
	return ByteValue{
	value: uint32(value),
	unit: unit,
	}
	}
	var zeroBytes = byteValue{value: 0, unit: Byte}
	type ByteValue interface {
	Value() uint32
	Unit() ByteUnit
	}
	type byteValue struct {
	// Value is the whole non-negative number of bytes of the specified unit
	value uint32
	// Unit is the unit of the byte value
	unit ByteUnit
	}
	func NewByteValue(value int32, unit ByteUnit) ByteValue {
	if value < 0 {
	return zeroBytes
	}
	return byteValue{
	value: uint32(value),
	unit: unit,
	}
	}
	func (b byteValue) Value() uint32 {
	return b.value
	}
	func (b byteValue) Unit() ByteUnit {
	return b.unit
	}

so that we don't have to expose the struct and callers must use NewByteValue

[drewmalin]

I like it