Conversation
drewmalin
commented
Aug 26, 2025
Comment on lines
+30
to
+31
| ARTIFACT_GOLINT=github.com/golangci/golangci-lint/cmd/golangci-lint@v1.64.8 | ||
| ARTIFACT_GOSEC=github.com/securego/gosec/v2/cmd/gosec@v2.22.8 |
Contributor
Author
There was a problem hiding this comment.
Pinning these to make the associated targets run much faster -- though we should consider upgrading golangci-lint to v2.
drewmalin
commented
Aug 26, 2025
Comment on lines
-107
to
-112
| @if command -v $(GOLINT) > /dev/null; then \ | ||
| $(GOLINT) run ./...; \ | ||
| else \ | ||
| echo "golangci-lint not found. Installing..."; \ | ||
| go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest; \ | ||
| $(GOLINT) run ./...; \ |
Contributor
Author
There was a problem hiding this comment.
Simplifies the logic down to one GOLINT call
drewmalin
commented
Aug 26, 2025
Makefile
Outdated
| .PHONY: fmt-check | ||
| fmt-check: | ||
| @echo "Checking code formatting..." | ||
| @if [ "$$(gofmt -s -l . | wc -l)" -gt 0 ]; then \ |
Contributor
Author
There was a problem hiding this comment.
Simplifies the logic down to one GOFMT call
drewmalin
commented
Aug 26, 2025
Comment on lines
-143
to
-145
| @if command -v $(GOSEC) > /dev/null; then \ | ||
| $(GOSEC) ./...; \ | ||
| else \ |
Contributor
Author
There was a problem hiding this comment.
Simplifies the logic down to one GOSEC call
drewmalin
commented
Aug 26, 2025
| .PHONY: deps-update | ||
| deps-update: | ||
| @echo "Updating dependencies..." | ||
| $(GOMOD) get -u ./... |
Contributor
Author
There was a problem hiding this comment.
go mod get is not a command -- this was intended to be go get
drewmalin
commented
Aug 26, 2025
Comment on lines
+194
to
+197
| $(GOINSTALL) $(ARTIFACT_GOLINT) | ||
| $(GOINSTALL) $(ARTIFACT_GOSEC) |
Contributor
Author
There was a problem hiding this comment.
Reference the tooling as variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.