Open
Conversation
ntBre
added a commit
to astral-sh/ruff
that referenced
this pull request
Jan 26, 2026
Summary -- I was initially just debugging astral-sh/ruff-action#307 with Claude and was quite skeptical when it started rewriting the [`is-wsl`] crate, but after taking a closer look at `is-wsl` and its dependency [`is-docker`], I thought it might actually be worth doing. This PR fixes astral-sh/ruff-action#307 by essentially inlining both the `is-wsl` and `is-docker` crates and expanding the `is_docker` check to account for additional types of containers. These crates are both one-file dependencies that haven't been updated in a couple of years. As shown in the debug logs from my comment on the issue, the minimal change to resolve the problem for the `ubuntu-slim` GitHub runner is to check for `/run/.containerenv` in addition to `/.dockerenv`, but Claude added a few additional checks on the `cgroup` to cover LXC and kubernetes containers too. Test Plan -- I forked the reproduction repo shared in the issue and tested that the Ruff version on this branch produces an `EXE001` diagnostic, as expected: brentbot/my-ruff-issue#1 [`is-wsl`]: https://github.com/TheLarkInn/is-wsl/blob/main/src/lib.rs [`is-docker`]: https://github.com/TheLarkInn/is-docker/blob/main/src/lib.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.