Skip to content

Fix React.act infrastructure issue in jsdom component tests #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brendanlong wants to merge 1 commit into from
Closed

Fix React.act infrastructure issue in jsdom component tests #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions vitest.component.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ import { defineConfig } from 'vitest/config';
import path from 'path';

export default defineConfig({
define: {
'process.env.NODE_ENV': JSON.stringify('test'),
},
test: {
Comment on lines +5 to 8
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using define for process.env.NODE_ENV is a literal string replacement that only affects code using the exact process.env.NODE_ENV syntax. It may fail to cover cases where the environment variable is accessed via destructuring (e.g., const { NODE_ENV } = process.env) or bracket notation (e.g., process.env['NODE_ENV']).

For a more robust solution in Vitest, it is recommended to use the test.env configuration. Alternatively, setting the environment variable in the package.json test script (e.g., NODE_ENV=test vitest ...) ensures it is correctly set for the entire process, including the resolver and all dependencies.

Suggested change
define: {
'process.env.NODE_ENV': JSON.stringify('test'),
},
test: {
test: {
env: {
NODE_ENV: 'test',
},

globals: true,
environment: 'jsdom',
Expand Down
Loading