Skip to content

Move to Imagemagick #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brandur wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move to Imagemagick #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- name: Install tooling from Apt
# Postgres runs in a container, but we also need the client-side
# tooling.
run: sudo apt-get install awscli imagemagick graphicsmagick postgresql
run: sudo apt-get install awscli imagemagick postgresql

- uses: actions/checkout@v1
with:
Expand All @@ -56,6 +56,8 @@ jobs:
echo "GITHUB_WORKSPACE=${GITHUB_WORKSPACE}"
echo "GOPATH=${GOPATH}"
echo "GOROOT=${GOROOT}"
echo ""
convert --version

- name: Clean
run: make clean
Expand Down
5 changes: 4 additions & 1 deletion build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2197,7 +2197,10 @@ func renderTwitter(c *modulir.Context, db *sql.DB) (bool, error) {

func resizeImage(c *modulir.Context, source, target string, width int) error {
cmd := exec.Command(
"gm",
// Better to use the less-generic `convert` leader, but need
// Imagemagick 7.0 for this. Wait a little longer, and then upgrade.
//
// "magick",
"convert",
source,
"-auto-orient",
Expand Down