Fix CI: propagate bg logger across threads for openai-agents >= 0.8 #1344
+24
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ai-agents >= 0.8 openai-agents 0.8.0 runs sync @function_tool functions via asyncio.to_thread(), which copies ContextVar context but not threading.local() state. The background logger override (_override_bg_logger) was threading.local(), so spans created in tool worker threads logged to the wrong (real HTTP) logger instead of the test memory logger -- causing test_agents_tool_openai_nested_spans to fail. Changes: - Change _override_bg_logger from threading.local() to ContextVar so it propagates via asyncio.to_thread() while remaining isolated per-context - Call setup_threads() in BraintrustTracingProcessor.__init__() to propagate ContextVars across ThreadPoolExecutor worker threads - Add test_openai_agents nox session with version matrix (latest, 0.8.0, 0.7.0) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_override_bg_loggerwasthreading.local(), which doesn't propagate to child threads.openai-agents0.8.0 runs sync@function_toolfunctions viaasyncio.to_thread(), so spans created in tool worker threads logged to the wrong (real HTTP) logger instead of the test memory logger._override_bg_loggerfromthreading.local()toContextVarso it propagates viaasyncio.to_thread()while remaining isolated per-contextsetup_threads()call inBraintrustTracingProcessor.__init__()to propagateContextVarcontext acrossThreadPoolExecutorworker threadstest_openai_agentsnox session with version matrix (latest, 0.8.0, 0.7.0) for independent agents SDK version testingTest plan
test_agents_tool_openai_nested_spanspasses (was failing)test_openai_agents(latest),test_openai_agents(0.8.0),test_openai_agents(0.7.0)sessions🤖 Generated with Claude Code